Skip to content

Added support for protobuf #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Added support for protobuf #341

merged 1 commit into from
Jun 9, 2022

Conversation

foram-splunk
Copy link
Contributor

No description provided.

@foram-splunk foram-splunk requested a review from hvaghani221 June 7, 2022 19:19
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results

147 tests   147 ✔️  37s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 3be19a2.

@foram-splunk foram-splunk changed the title Added protobuf support Added support for protobuf Jun 7, 2022
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@foram-splunk foram-splunk requested a review from artemrys June 8, 2022 06:10
@artemrys
Copy link
Member

artemrys commented Jun 8, 2022

I guess protobuf support was done somewhere else, this PR seems to bring more testing into it?

@foram-splunk
Copy link
Contributor Author

foram-splunk commented Jun 9, 2022

The connector doesn’t need to add logic to deserialize the event. Connector only needs to provide converter’s classpath to Kafka connect. I have used confluent's Kafka Connect Protobuf Converter to deserialize topic events.

Brief about converters: Converters help to change the format of data from one format into another format. Converters are decoupled from connectors to allow the reuse of converters between connectors naturally. The Converter used at Source and Sink can take input and output to different set of formats.
(https://docs.oracle.com/en/cloud/paas/event-hub-cloud/admin-guide/kafka-connect-converters.html#:~:text=Converters%20help%20to%20change%20the,to%20different%20set%20of%20formats)

Below image is for Kafka source connect. It will be similar for Kafka sink connect as well. So, the event flow would be:
Kafka -> Converter -> Connector -> Destination(Splunk)

image

@foram-splunk foram-splunk merged commit d2871ea into develop Jun 9, 2022
This was referenced Jun 9, 2022
@aryznar-splunk aryznar-splunk deleted the protobuf-support branch June 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants