Add github actions ci pipeline #286
Conversation
mwang2016
force-pushed
the
github-ci-pipeline
branch
from
21f40d3 to
589a84b
Compare
Unit Test Results 23 files 23 suites 38s ⏱️ Results for commit 9819ae7. ♻️ This comment has been updated with latest results. |
mwang2016
force-pushed
the
github-ci-pipeline
branch
28 times, most recently
from
87a7f99 to
092d0c3
Compare
mwang2016
force-pushed
the
github-ci-pipeline
branch
11 times, most recently
from
0d75759 to
5b11f69
Compare
| kafka_package: "kafka_2.11-2.0.0.tgz" | ||
| - kafka_version: "2.1.0" | ||
| kafka_package: "kafka_2.12-2.1.0.tgz" | ||
| - kafka_version: "2.6.0" |
There was a problem hiding this comment.
can we add support for kafka 2.8.0 and kafka 2.7.1?
There was a problem hiding this comment.
sure, i will add them
.github/workflows/ci_build_test.yaml
Outdated
| - kafka_version: "2.6.0" | ||
| kafka_package: "kafka_2.13-2.6.0.tgz" | ||
| env: | ||
| CI_SPLUNK_VERSION: "8.2.0" |
There was a problem hiding this comment.
can we use splunk 8.2.2?
.github/workflows/ci_build_test.yaml
Outdated
| CI_KAFKA_HEADER_INDEX: kafka | ||
| CI_DATAGEN_IMAGE: rock1017/log-generator:latest | ||
| CI_OLD_CONNECTOR_VERSION: v1.2.0 | ||
| KUBERNETES_VERSION: v1.15.2 |
There was a problem hiding this comment.
we dont use k8s and minikube here
There was a problem hiding this comment.
Yes, it was a mistake, I thought i would install splunk on kubernetes, forgot to remove it after.
.github/workflows/ci_build_test.yaml
Outdated
| CI_INDEX_EVENTS: main | ||
| CI_KAFKA_HEADER_INDEX: kafka | ||
| CI_DATAGEN_IMAGE: rock1017/log-generator:latest | ||
| CI_OLD_CONNECTOR_VERSION: v1.2.0 |
There was a problem hiding this comment.
this can be changed to 2.0.2 now right?
There was a problem hiding this comment.
It is the old version of connector that I need to use for testing upgrade. So you mean we should test upgrade with the last version?
test/config.yaml
Outdated
| kafka_home: /usr/local/kafka | ||
| kafka_connect_home: /home/circleci/repo | ||
| old_connector_name: splunk-kafka-connect-v1.2.0.jar | ||
| old_connector_name: splunk-kafka-connect-v1.2.0.jar |
There was a problem hiding this comment.
can be changed if we change the old connector version
There was a problem hiding this comment.
this should be 2.0.1 right?
test/lib/commonkafka.py
Outdated
| @@ -74,7 +74,7 @@ def delete_kafka_connector(setup, connector): | |||
| response = requests.delete(url=setup["kafka_connect_url"] + "/connectors/" + connector, | |||
| headers={'Accept': 'application/json', 'Content-Type': 'application/json'}) | |||
| if response.status_code == 204: | |||
| logger.info("Deleted connector successfully - " + connector) | |||
| # logger.info("Deleted connector successfully - " + connector) | |||
There was a problem hiding this comment.
can be changed to debug
mwang2016
force-pushed
the
github-ci-pipeline
branch
7 times, most recently
from
63beef7 to
c6c4c1c
Compare
mwang2016
force-pushed
the
github-ci-pipeline
branch
2 times, most recently
from
602d4e5 to
492051f
Compare
test/config.yaml
Outdated
| kafka_home: /usr/local/kafka | ||
| kafka_connect_home: /home/circleci/repo | ||
| old_connector_name: splunk-kafka-connect-v1.2.0.jar | ||
| old_connector_name: splunk-kafka-connect-v1.2.0.jar |
There was a problem hiding this comment.
this should be 2.0.1 right?
mwang2016
force-pushed
the
github-ci-pipeline
branch
from
492051f to
9819ae7
Compare
No description provided.