Skip to content

Lookup validation - Ignore local=true #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Lookup validation - Ignore local=true #82

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedfef2
Ignore local=true
0xC0FFEEEE Nov 22, 2023
186854f
Merge branch 'main' into bugfix-local-lookup
pyth0n1c Apr 5, 2024
9438cc9
Merge branch 'main' into bugfix-local-lookup
pyth0n1c Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contentctl/objects/lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def name_max_length(cls, v):

@staticmethod
def get_lookups(text_field: str, all_lookups: list[Lookup], ignore_lookups:set[str]=LOOKUPS_TO_IGNORE)->Tuple[list[Lookup], set[str]]:
lookups_to_get = set(re.findall(r'[^output]lookup (?:update=true)?(?:append=t)?\s*([^\s]*)', text_field))
lookups_to_get = set(re.findall(r'[^output]lookup (?:local=true)?(?:update=true)?(?:append=t)?\s*([^\s]*)', text_field))
lookups_to_ignore = set([lookup for lookup in lookups_to_get if any(to_ignore in lookups_to_get for to_ignore in ignore_lookups)])
lookups_to_get -= lookups_to_ignore
found_lookups, missing_lookups = SecurityContentObject.get_objects_by_name(lookups_to_get, all_lookups)
Expand Down