Enable scripted fixing of detection metadata validation errors #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snippet of current output:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we make changes to the .conf templates or want to make large changes to content, we frequently have to manipulate versions for many detections at once. This is currently a gigantic pain, and has no easy way to go about fixing, especially given the implicit promise we have of not modifying files in an app without that being the express intent of the command.
This PR makes a first attempt at identifying the errors where we know something is incorrect AND we specifically know what the value SHOULD be. During the
contentctl inspectworkflow, these errors are printed on the screen and now a JSON representation of them is saved tometadata_validation_errors.json, where they can be processed by another tool.I also realized we didn't necessarily account for versions being bumped when they didn't have to, and added a new error type to account for those.