Skip to content

Ensure we print the right field for data_source #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

ljstella
Copy link
Contributor

@ljstella ljstella commented Nov 6, 2024

data_source is distinct and different than data_sources - we don't appear to have made that distinct enough in some places so even we have made use of the wrong one in some places.

@ljstella ljstella requested a review from pyth0n1c November 6, 2024 15:36
@ljstella ljstella self-assigned this Nov 6, 2024
@ljstella ljstella marked this pull request as ready for review November 6, 2024 15:36
@patel-bhavin
Copy link
Contributor

👍 - Looks good!

Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, thanks for the fix!

@pyth0n1c pyth0n1c merged commit 3c733f1 into main Nov 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants