-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add tests versioning #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Let me review this pull request. Suggested pull request title: Thank you for implementing this valuable feature for version-specific test filtering. The implementation is clean and well-documented, with good consideration for backward compatibility by making the The changes could benefit from a few minor improvements to make the feature more robust and user-friendly. Here are my specific suggestions:
After implementing these suggestions, the code will be ready for merging. This comment was added by our PR Review Assistant Bot. Please kindly acknowledge that To reply to the review and engage Review Bot in further conversation, start your comment with the words |
Suggested pull request title: Thank you for implementing the test versioning feature. The code is well-organized and includes both implementation and documentation, which is great to see. The version range decorator will be very useful for managing version-specific test cases. There are a few areas where the implementation could be improved for better robustness and clarity. Here are the specific suggestions:
After implementing these suggestions, the code will be ready for merging. The core functionality is solid, and these changes will just make it more robust and user-friendly. This comment was added by our PR Review Assistant Bot. Please kindly acknowledge that To reply to the review and engage Review Bot in further conversation, start your comment with the words |
) | ||
config.hook.pytest_deselected(items=excluded_items) | ||
items[:] = [item for item in items if item not in excluded_items] | ||
|
||
skipped_tests = _collect_skipped_tests(items) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Framework need to know what test has been skipped to update internal data accordingly. Please update item removal code to save skipped test list in skipped_tests variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing - PytestConfigAdapter is not updated to handle ta_version property
@kgwizdz-splunk , |
Would appreciate some tests as well. |
No description provided.