feat: add default and custom validations for name field #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sgoral-splunk
changed the title
sgoral-splunk
requested review from
artemrys,
hetangmodi-crest and
lplonka-splunk
lplonka-splunk
previously approved these changes
Sep 25, 2024
artemrys
requested changes
Sep 25, 2024
Contributor
|
Integration test are failing, can you please fix it. |
hetangmodi-crest
previously approved these changes
Oct 1, 2024
artemrys
previously approved these changes
Oct 8, 2024
|
|
||
| class RestModel: | ||
| def __init__(self, fields, name=None): | ||
| def __init__(self, fields, name=None, special_fields: List[RestField] = None): |
| "displayName": "Demo", | ||
| "schemaVersion": "0.0.3" | ||
| "schemaVersion": "0.0.8", | ||
| "_uccVersion": "5.45.0" |
Member
There was a problem hiding this comment.
nit: _uccVersion is a run time configuration
artemrys
approved these changes
Oct 9, 2024
Contributor
|
🎉 This PR is included in version 6.4.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:ADDON-74237
Summary
Added support for default and custom name field validation
Changes
User experience
Name field will be validated on the server side
Checklist
If your change doesn't seem to apply, please leave them unchecked.