Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better exception handling when could not get the version from git tags #476

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented Jul 4, 2022

Related to #404

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #476 (1e05db4) into main (7432949) will decrease coverage by 0.12%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   78.90%   78.77%   -0.13%     
==========================================
  Files          27       27              
  Lines        1730     1734       +4     
==========================================
+ Hits         1365     1366       +1     
- Misses        365      368       +3     
Impacted Files Coverage Δ
splunk_add_on_ucc_framework/__init__.py 76.51% <40.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7432949...1e05db4. Read the comment docs.

@artemrys artemrys force-pushed the better-error-handling-for-git-issue branch from 559d4c1 to 1e05db4 Compare July 4, 2022 12:31
@artemrys artemrys changed the title fix: better exception handling for #404 fix: better exception handling when could not get the version from git tags Jul 4, 2022
@artemrys artemrys merged commit 2aafc09 into main Jul 4, 2022
@artemrys artemrys deleted the better-error-handling-for-git-issue branch July 4, 2022 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants