Skip to content

chore: merge develop into main #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 19, 2025
Merged

chore: merge develop into main #444

merged 22 commits into from
Jun 19, 2025

Conversation

hetangmodi-crest
Copy link
Contributor

No description provided.

sgoral-splunk and others added 20 commits May 23, 2025 09:21
**Issue number:
[ADDON-79884](https://splunk.atlassian.net/browse/ADDON-79884)**

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [x] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [ ] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

`solnlib` will no longer use Splunk's `btool`. `btool` was replaced with
configuration endpoint from Splunk `splunk.rest` module. Since
`session_key` is required for an authorization, `solnlib` no longer
supports `get_session_key()` function. Also function
`make_splunkhome_path` will now use native Splunk's implementation from
`splunk.clilib.bundle_paths`

### User experience

It's a breaking change for the user as functions related to getting
stanza from config files will now required `app_name` and `session_key`
to work properly.

If users uses `get_session_key()` from `solnlib` they will need to
replace it with their own implementation.

## Checklist

introduced new method `_get_conf_stanzas_from_splunk_api`
Following functions will now require app_name and/or session_key as a
arguments to work:
* get_conf_stanza
* get_conf_key_value
* get_splunkd_uri
* get_scheme_from_hec_settings
* get_splunkd_access_info
* get_splunk_host_info

make_splunkhome_path() now uses
`splunk.clilib.bundle_paths.make_splunkhome_path`

### Review

* [x] self-review - I have performed a self-review of this change
according to the [development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [ ] Changes are documented. The documentation is understandable,
examples work [(more
info)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#documentation-guidelines)
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
* [ ] meeting - I have scheduled a meeting or recorded a demo to explain
these changes (if there is a video, put a link below and in the ticket)

### Tests

See [the testing
doc](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test).

* [ ] Unit - tests have been added/modified to cover the changes
* [ ] Smoke - tests have been added/modified to cover the changes
* [ ] UI - tests have been added/modified to cover the changes
* [x] coverage - I have checked the code coverage of my changes [(see
more)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#checking-the-code-coverage)

**Demo/meeting:**

*Reviewers are encouraged to request meetings or demos if any part of
the change is unclear*
# [6.3.0-beta.2](v6.3.0-beta.1...v6.3.0-beta.2) (2025-06-19)

### Features

* init commit, new function to retrieve stanzas based on rest ([ae2b3ab](ae2b3ab))
* init commit, new function to retrieve stanzas based on rest ([619a53e](619a53e))
BREAKING CHANGE: Replacing the usage of btool with splunk.rest
@hetangmodi-crest hetangmodi-crest self-assigned this Jun 19, 2025
hetangmodi-crest and others added 2 commits June 19, 2025 17:00
# [7.0.0-beta.1](v6.3.0...v7.0.0-beta.1) (2025-06-19)

### Features

* **code:** replace btool with splunk.rest ([d7fce46](d7fce46))
* init commit, new function to retrieve stanzas based on rest ([ae2b3ab](ae2b3ab))
* init commit, new function to retrieve stanzas based on rest ([619a53e](619a53e))

### BREAKING CHANGES

* **code:** Replacing the usage of btool with splunk.rest
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review June 19, 2025 13:10
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner June 19, 2025 13:10
@hetangmodi-crest hetangmodi-crest merged commit e58b03b into main Jun 19, 2025
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants