Update Trial so that goals are accessible in callback #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-phung
force-pushed
the
trial-goal-callback
branch
from
632b19f to
00748fd
Compare
andrehjr
reviewed
Jun 4, 2020
andrehjr
reviewed
Jun 4, 2020
andrehjr
approved these changes
Jun 4, 2020
Member
andrehjr
left a comment
andrehjr
left a comment
There was a problem hiding this comment.
Looks good! Thanks for cleaning up those specs!
I've found a small typo. If you can fix that I'll merge :)
Contributor
Author
|
Oops! As suggested spec copy has been fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
When using goals the
on_trial_completedoes not have scope to the#ab_finishedsupplied goals.How does this solve it?
Updates the Trial to initialize with goals so that they are accessible in the callback when passing the trial into the callback.
Notes: Fixed and cleaned up specs.