Skip to content

Conversation

@robin-phung
Copy link
Contributor

What problem does this solve?

Removes code that is not called(?) and has already been addressed in extract_alternatives_from_options(). More specifically the function checks whether or not the alternatives were passed via the options as params, which will then already proceeds to try loading them from Split.configuration.experiments ~> no reason for the outer initialize() to try to do the same.

Why is this useful?

  • Makes it easier to read

How does this solve it?

  • Removes code from initialize

@robin-phung robin-phung changed the title removed unreached loading from config Removed repeated loading from config May 13, 2020
@andrehjr
Copy link
Member

Thanks @robin-phung

@andrehjr andrehjr merged commit 0eab0ae into splitrb:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants