Respect experiment defaults when loading experiments in initializer. #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwd7
force-pushed
the
bug-default-experiment-resettable-when-loaded-from-configuration
branch
from
a866330 to
6fa6032
Compare
andrehjr
approved these changes
Dec 5, 2019
Member
andrehjr
left a comment
andrehjr
left a comment
There was a problem hiding this comment.
I think this is enough for now. So I'll merge this. There are some duplicated bits on this class that I wish to refactor even further.
Sorry for taking so long, I was away for a little while and also spoke at a conference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #598