Make dashboard pagination default "per" param configurable #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some people (like me) may prefer slower initial dashboard pageloads then searching within the page vs. having to load many pages to try and find the A/B test of interest to them. Making the default "tests per page" parameter configurable gives that flexibility. Test Plan: rspec
Test Plan: rspec
andrehjr
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people (like me) may prefer slower initial dashboard pageloads then
searching within the page vs. having to load many pages to try and find
the A/B test of interest to them.
Making the default "tests per page" parameter configurable gives that flexibility.
Test Plan:
rspec