Skip to content

Conversation

@gnanou
Copy link
Contributor

@gnanou gnanou commented Jun 26, 2019

Reduce the number of redundant Redis operations executed for the same request. This way the performance of a test with combined experiments is expected to improve.

  • Cache Experiment#has_winner? result for the lifetime of an experiment instance
  • Remove redundant calls to Redis in Experiment#save
  • Cleanup Split user old experiments only once during the lifetime of a User instance
  • Specs added

--
Resolves issue #573

@andrehjr
Copy link
Member

andrehjr commented Jul 6, 2019

Thanks so much for your PR, I made a lot of tests and the number of calls to redis reduced a lot.

I see that there's still a lot to be on how Split handles calls to redis!

@andrehjr andrehjr merged commit 66a4dfc into splitrb:master Jul 6, 2019
@gnanou
Copy link
Contributor Author

gnanou commented Jul 8, 2019

That's great, thanks a lot for reviewing!
Btw, have you thought yet when the next release will be? Just wondering, I will be watching it in any case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants