Combined experiment performance improvements#575
Merged
andrehjr merged 3 commits intosplitrb:masterfrom Jul 6, 2019
Merged
Conversation
Check if an experiment is new or its configuration has changed only once
andrehjr
approved these changes
Jul 6, 2019
Member
|
Thanks so much for your PR, I made a lot of tests and the number of calls to redis reduced a lot. I see that there's still a lot to be on how Split handles calls to redis! |
Contributor
Author
|
That's great, thanks a lot for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the number of redundant Redis operations executed for the same request. This way the performance of a test with combined experiments is expected to improve.
Experiment#has_winner?result for the lifetime of an experiment instanceExperiment#save--
Resolves issue #573