Fix force_aleternative for experiments with incremented version
#565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrehjr
reviewed
Jun 3, 2019
andrehjr
reviewed
Jun 3, 2019
andrehjr
requested changes
Jun 3, 2019
Member
andrehjr
left a comment
andrehjr
left a comment
There was a problem hiding this comment.
Overall looks good 🙌 left minor style comments.
- Remove an unneeded debug code - Put the before block after the let! line in spec
Conflicts: spec/dashboard_spec.rb
Contributor
Author
|
Sorry, I find a mistake in this PR. Please wait for reviewing. |
Contributor
Author
|
This PR didn't take my own patch (#567) into consideration. So I think that I will close this and resend another patch later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dashboard,
force_alternativedoesn't work for experiments with incremented version to look for key without version.This PR fixes this issue and
force_alternativeworks for experiments with incremented version.