Fix binding of ignore_filter #533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the context in which the
ignore_filteris called. This is needed when using the helper methods in a context of an eg. Rails helper.To illustrate the difference:
When calling
ab_testin a controller, the output is:But when using
ab_testin a helper, the output is:This is especially funky due to Rails' delegation of eg.
#headers, meaning that callingrequest.headersin theignore_filterwould have two different meanings - in helpers, it would callheaderson the response, while in controllers it would callheaderson the request (as intended)This PR fixes the issue and should preserve backwards-compatibility (for methods with
requestas argument in the proc).