Skip to content

Improve performance of RedisInterface#make_list_length by using LTRIM command #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew merged 1 commit into from
Jan 23, 2018
Merged

Improve performance of RedisInterface#make_list_length by using LTRIM command #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/split/redis_interface.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ def remove_last_item_from_list(list_name)
end

def make_list_length(list_name, new_length)
while list_length(list_name) > new_length
remove_last_item_from_list(list_name)
end
redis.ltrim(list_name, 0, new_length - 1)
end

def add_to_set(set_name, value)
Expand Down