Use treatment config for object evaluation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzrf0cuz
pushed a commit
to lzrf0cuz/split-openfeature-provider-go
that referenced
this pull request
Nov 11, 2025
Document two critical bugs that must be fixed: 1. Bug splitio#1: Dynamic Configurations don't work - ObjectEvaluation uses Treatment() instead of TreatmentWithConfig() - Tries to parse treatment name as JSON instead of config field - Prevents use of Split.io Dynamic Configurations feature - Fix: Use TreatmentWithConfig() and extract config field 2. Bug splitio#2: Attributes not passed to Split SDK - evaluateTreatment() passes nil for attributes parameter - Breaks all attribute-based targeting rules - Users cannot leverage Split.io targeting capabilities - Fix: Convert OpenFeature context to attributes map Both bugs validated against: - Split.io Go SDK v6.8.1 documentation - Flashgap's PR splitio#3 (object evaluation fix) - snap-one's fork (attribute passing enhancement) - Official Harness/Split.io documentation Includes: - Root cause analysis with code references - Impact assessment - Detailed solution with code examples - Test cases for validation - Implementation priority (Phase 0 - before lifecycle) - Estimated effort (~5 hours) These fixes are REQUIRED before implementing the gold standard plan.
lzrf0cuz
pushed a commit
to lzrf0cuz/split-openfeature-provider-go
that referenced
this pull request
Nov 11, 2025
Fix Bug splitio#1: Dynamic Configurations not working - ObjectEvaluation now uses config field from TreatmentWithConfig() - Previously tried to parse treatment name as JSON (incorrect) - Now correctly uses Split.io Dynamic Configuration feature - Maintains backward compatibility (falls back to treatment if no config) - Add TestDynamicConfiguration to verify fix Fix Bug splitio#2: Attributes not passed to Split SDK - Create evaluateTreatmentWithConfig() helper function - Extracts targeting key and builds attributes map from evalContext - Calls TreatmentWithConfig() with attributes for targeting rules - Update evaluateTreatment() to use new helper (backward compatible) - Add TestAttributesPassedToSplit to verify attributes work Implementation: - provider.go: Add evaluateTreatmentWithConfig() with full godoc - provider.go: Update ObjectEvaluation to use config field - provider.go: Update evaluateTreatment to call new helper - provider_test.go: Add TestAttributesPassedToSplit - provider_test.go: Add TestDynamicConfiguration - go.mod: Fix Go version from 1.25.3 to 1.21 (1.25 doesn't exist) Results: - All 22 tests pass (21 existing + 2 new) - Backward compatibility maintained - Critical functionality restored Validates community fork fixes: - Flashgap PR splitio#3: Object evaluation bug - snap-one: Attribute passing enhancement Resolves issues documented in CRITICAL_BUGS.md Phase 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the provider doesn't work when trying to fetch a Dynamic Configuration from Split.io.
This PR makes it work by using the actual config instead of the variant name.