Add murmur hash support #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following issues:
cpphash
which builds and enables a C++ implementation of this hash function.In order to include the C++ implementation of this hash function, a fork was created for this project https://github.com/splitio/mmh3, which was adapted to support Python2 as well and then published to SplitIO's Pypi account.
This can be tested locally using the following commands:
virtualenv -p <PYTHON_EXECUTABLE> venv & source venv/bin/activate
git clone https://github.com/splitio/python-client
cd python-client
pip install -e .
(python implmementation of hash) orpip install -e .[cpphash]
(C++ implementation).python setup.py nosetests
PYTHON_EXECUTABLE can be used to select which python version (installed on your system) should be used to create the virtualenv where the client will be tested.
Once this is published to PyPI it will be possible to install it using:
pip install splitio
orpip install splitio[redis]
orpip install splitio[redis,cpphash]
,etc...