Fix url exceptions

CHANGES.txt

@@ -1,6 +1,8 @@
+2.1.x
+ - Fixed HTTP status code exceptions
 2.1.0
  - Added enabled labels
  - Added impressions by sdk and version including bucketing key
 2.0.5
  - Added SDK Factory Method with Manager API and Sdk Client
- - Added Bucketing key support
+ - Added Bucketing key support

splitio/api.py

@@ -2,6 +2,7 @@
 from __future__ import absolute_import, division, print_function, unicode_literals
 
 import requests
+import logging
 
 from splitio.config import SDK_API_BASE_URL, EVENTS_API_BASE_URL, SDK_VERSION
 
@@ -38,6 +39,7 @@ def __init__(self, api_key, sdk_api_base_url=None, events_api_base_url=None,
         :param read_timeout: The HTTP read timeout. Default: 1000 (seconds)
         :type read_timeout: float
         """
+        self._logger = logging.getLogger(self.__class__.__name__)
         self._api_key = api_key
         self._sdk_api_url_base = sdk_api_base_url if sdk_api_base_url is not None \
             else SDK_API_BASE_URL
@@ -83,19 +85,27 @@ def _build_headers(self):
 
         return headers
 
+    def _logHttpError(self, response):
+        if response.status_code < 200 or response.status_code >= 400 :
+            respJson = response.json()
+            if 'message' in respJson:
+                self._logger.error("HTTP Error (status: %s) connecting with split servers: %s" % (response.status_code, respJson['message']))
+            else:
+                self._logger.error("HTTP Error connecting with split servers")
+
     def _get(self, url, params):
         headers = self._build_headers()
 
         response = requests.get(url, params=params, headers=headers, timeout=self._timeout)
-        response.raise_for_status()
+        self._logHttpError(response)
 
         return response.json()
 
     def _post(self, url, data):
         headers = self._build_headers()
 
         response = requests.post(url, json=data, headers=headers, timeout=self._timeout)
-        response.raise_for_status()
+        self._logHttpError(response)
 
         return response.status_code
 

splitio/tests/test_api.py

@@ -139,13 +139,14 @@ def test_request_exceptions_are_raised(self):
         with self.assertRaises(RequestException):
             self.api._get(self.some_url, self.some_params)
 
-    def test_request_status_exceptions_are_raised(self):
-        """Tests that if requests succeeds but its status is not 200 (Ok) an exception is raised
-        and , it is not handled within the call"""
+    def test_request_status_exceptions_are_not_raised(self):
+        """Tests that if requests succeeds but its status is not 200 (Ok) an exception is not raised"""
         self.requests_get_mock.return_value.raise_for_status.side_effect = HTTPError()
 
-        with self.assertRaises(HTTPError):
+        try:
             self.api._get(self.some_url, self.some_params)
+        except:
+            self.assertTrue(False)
 
     def test_json_exceptions_are_raised(self):
         """Tests that if requests succeeds but its payload is not JSON, an exception is raised and
@@ -214,13 +215,14 @@ def test_request_exceptions_are_raised(self):
         with self.assertRaises(RequestException):
             self.api._post(self.some_url, self.some_data)
 
-    def test_request_status_exceptions_are_raised(self):
-        """Tests that if requests succeeds but its status is not 200 (Ok) an exception is raised
-        and , it is not handled within the call"""
+    def test_request_status_exceptions_are_not_raised(self):
+        """Tests that if requests succeeds but its status is not 200 (Ok) an exception is not raised"""
         self.requests_post_mock.return_value.raise_for_status.side_effect = HTTPError()
 
-        with self.assertRaises(HTTPError):
+        try:
             self.api._post(self.some_url, self.some_data)
+        except:
+            self.assertTrue(False)
 
 
 class SdkApiSplitChangesTest(TestCase, MockUtilsMixin):