Breaking changes #827
Merged
Breaking changes #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
changed the base branch from
SDKS-8407_baseline
to
add_factory_destroy_method
EmilianoSanchez
changed the base branch from
add_factory_destroy_method
to
rename_dist_folders
Refactor: updated internal modules
Refactor TypeScript declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
MapandSetglobal objects, dropping support for IE and other outdated browsers. The SDK now requires the runtime environment to support these features natively or provide a polyfill.GOOGLE_ANALYTICS_TO_SPLITandSPLIT_TO_GOOGLE_ANALYTICSintegrations.core.trafficTypeconfiguration option and thetrafficTypeparameter from the SDKclient()method in Browser (SplitIO.IBrowserSDK['client']). As a result, traffic types can no longer be bound to SDK clients, and the traffic type must be provided in thetrackmethod.How do we test the changes introduced in this PR?
Extra Notes