[FME-4033] prerequisites evaluator #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCardozo-SDK
changed the base branch from
master
to
FME-2963-prerequisites_baseline
sanzmauro
requested changes
May 26, 2025
|
I have them in the next PR (since in this one the Matcher always returns true) |
gthea
reviewed
May 27, 2025
gthea
reviewed
May 27, 2025
|
There are new tests. This matcher is the only one that the evaluator must know, so I wasn't sure about the best way of linking them and testing it. I would appreciate some feedback on that. |
sanzmauro
changed the title
sanzmauro
changed the title
MartinCardozo-SDK
changed the base branch from
FME-2963-prerequisites_baseline
to
FME-2963-prerequisites_matcher
MartinCardozo-SDK
changed the base branch from
FME-2963-prerequisites_matcher
to
FME-2963_prerequisites_matcher
MartinCardozo-SDK
changed the base branch from
FME-2963_prerequisites_matcher
to
FME-2963-prerequisites_matcher
gthea
approved these changes
May 28, 2025
Comment on lines
+180
to
+182
| internal func overridePrerequisitesMatcher(_ factory: @escaping ([Prerequisite]) -> MatcherProtocol) { | ||
| prerequisitesMatcherFactory = factory | ||
| } |
There was a problem hiding this comment.
Cool. Maybe I'd put it in an extension if possible but this is a good approach 👍
MartinCardozo-SDK
changed the base branch from
FME-2963-prerequisites_matcher
to
FME-2963-prerequisites_baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?
New PrerequisitesMatcher. New result label and new step in Evaluator (class cleanup too)
How do we test the changes introduced in this PR?
Extra Notes
Matcher in next PR