Sync batch coalescing #690
Merged
+220
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizardoluis
approved these changes
Oct 1, 2024
gruuya
force-pushed
the
sync-batch-merging
branch
from
686e269
to
22400e5
Compare
mildbyte
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Coalesce sync batches when enqueuing them. This ensures we stay below the
max_syncs_per_urlfor longer, ultimately enabling us to accumulate/dump more rows per flush.How
When enqueuing sync batches, if they share the same schema as a previous entry just append them to it, instead of creating a new entry.
Why
Whereas the existing implementation has been optimized for a high volume/saturating use case, this is not the case for the opposite, i.e. batches with a low number of rows. Consequently this leads to poor throughput rates, and ultimately slows down the transaction processing speed for the entire cluster.