Fix E_WARNING: array offset on null $INFO in _htmlform()#356
Open
eduardomozart wants to merge 5 commits intosplitbrain:masterfrom
Open
Fix E_WARNING: array offset on null $INFO in _htmlform()#356eduardomozart wants to merge 5 commits intosplitbrain:masterfrom
eduardomozart wants to merge 5 commits intosplitbrain:masterfrom
Conversation
This PR checks if form is dirty (aka. has been changed) before exiting the page, preventing that user looses it changes if it exits the page after changing the form data.
…allback to $ID Co-authored-by: eduardomozart <2974895+eduardomozart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$INFOis not initialized in CLI contexts (e.g., aichat'screateEmbeddings), causingE_WARNING: Trying to access array offset on nullwhen_htmlform()unconditionally accesses$INFO['id'].Changes
syntax.php—_htmlform(): Guard$INFO['id']withisset(), falling back to$ID— consistent with the same pattern already used inprepareNamespacetemplateReplacements()(line 578)