Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(include): correct syntax errors #964

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

y0hami
Copy link
Contributor

@y0hami y0hami commented Jan 13, 2023

Fix syntax error preventing compiling on latest sourcemod version

Fix syntax error preventing compiling on latest sourcemod version
@nickdnk
Copy link
Collaborator

nickdnk commented Jan 13, 2023

Hello

If you want to fix this, you have to make all required changes for SM 1.11 throughout the plugin, not just this one line. It's on the to-do for version 0.13. or 0.14. Until then, compile with 1.10.. Sorry. I misunderstood what was going on here.

@nickdnk nickdnk closed this Jan 13, 2023
@nickdnk
Copy link
Collaborator

nickdnk commented Jan 13, 2023

Ah, sorry. It seems there's a problem here with a missing argument. If you can change it to have the const while adding the event argument, it should be fine.

@nickdnk nickdnk reopened this Jan 13, 2023
@nickdnk nickdnk added the bug label Jan 13, 2023
scripting/include/get5.inc Outdated Show resolved Hide resolved
@y0hami
Copy link
Contributor Author

y0hami commented Jan 13, 2023

@nickdnk should be good now

@nickdnk nickdnk merged commit 4c71a3e into splewis:development Jan 13, 2023
@y0hami y0hami deleted the fix/syntax-errors branch January 13, 2023 04:18
nickdnk added a commit that referenced this pull request Jan 16, 2023
* Add missing event parameter to Get5_OnEvent forward (#964)
* Use correct argument for demo file deletion when using subfolders (#965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants