Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.9.23 update #771

Merged
merged 18 commits into from
May 10, 2024
Merged

Kotlin 1.9.23 update #771

merged 18 commits into from
May 10, 2024

Conversation

ChristoferAlexander
Copy link
Contributor

@ChristoferAlexander ChristoferAlexander self-assigned this May 7, 2024
@ChristoferAlexander ChristoferAlexander changed the base branch from develop to feature/1.4.0-RC2 May 7, 2024 13:44
@Daeda88
Copy link
Contributor

Daeda88 commented May 7, 2024

Can you just target develop please

Copy link
Contributor

@Daeda88 Daeda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should at the very least also update the compose compiler. Please build the example project to make sure it works

@ChristoferAlexander ChristoferAlexander changed the base branch from feature/1.4.0-RC2 to develop May 7, 2024 14:39
@ChristoferAlexander
Copy link
Contributor Author

Tested on example ok. Tried to update some other outdated dependencies but they seem to belong to a gradle-test-recorder submodule so probably need to be updated separate.

@Daeda88
Copy link
Contributor

Daeda88 commented May 7, 2024

You need to upgrade the test recorder as well to get ci to work

@leokapanen leokapanen merged commit 8e22d7d into develop May 10, 2024
55 of 63 checks passed
@leokapanen leokapanen deleted the feature/770-kotlin-update branch May 10, 2024 17:52
@leokapanen
Copy link
Contributor

Some Android UI tests are red but this instability is expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants