MockDevice support connect/disconnect #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run |
We need a checkmark in the description like [ ] I ran apiDump |
dasdranagon
approved these changes
Nov 27, 2023
|
Can we add a simple test, also to demonstrate usage? And a simple README entry. Looks good otherwise. |
Test added, README updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #750
Attempt to have MockDevice to be connectable and disconnectable
Current simple implementation of mock device a bit confusing.
After creating object and naive calling connect() it does nothing (even no log message that it is not supported or implemented).
This PR just keeps mock simple as it was but provides connect disconnect calls to behave similar to real world device.