Attempt to get if statement back & add artifacts

splendo · Jun 12, 2024 · c841281 · c841281
1 parent 65f33a2
commit c841281
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/.github/workflows/android.yaml b/.github/workflows/android.yaml
@@ -21,20 +21,28 @@ jobs:
 
       - name: run Android unit tests
         run: ./gradlew testDebugUnitTest koverHtmlReport koverXmlReport
-      - name: CHeck has token
-        run: |
-         echo ${{ secrets.CI_SPLENDO_PAT }}
-      - name: Test path
-        run: |
-          ls ${{ github.workspace }}/build/reports/kover
       - name: add coverage report to PR
         id: kover
         uses: mi-kas/kover-report@v1
+        # this action fails if there is no report, unlike the above actions, so check if there are files
+        if: ${{ always() && hashFiles(join(github.workspace,'/build/reports/kover/report.xml')) != '' }}
         with:
           path: ${{ github.workspace }}/build/reports/kover/report.xml
           token: ${{ secrets.CI_SPLENDO_PAT }}
           title: Code coverage
           update-comment: true
           coverage-counter-type: LINE
+      - name: Upload Android test artifact
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: "Android Test Report HTML"
+          path: "**/build/reports/tests/testDebugUnitTest"
+      - name: Upload Coverage report
+        uses: actions/upload-artifact@v3
+        if: ${{ always() && hashFiles(join(github.workspace,'/build/reports/kover/html/index.html')) != '' }}
+        with:
+          name: "Android Test Report HTML"
+          path: "**/build/reports/kover/html"
       - name: run apiCheck
         run: ./gradlew apiCheck
diff --git a/.github/workflows/ios.yaml b/.github/workflows/ios.yaml
@@ -55,3 +55,9 @@ jobs:
 
       - name: run iOS tests
         run: ./gradlew :${{ matrix.module }}:ios${{ runner.arch == 'X86' && 'X86' || runner.arch == 'X64' && 'x86_64' || runner.arch == 'ARM' && 'SimulatorArm32' || 'SimulatorArm64' }}Test
+      - name: Upload iOS test artifact
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: ${{ matrix.module}} iOS Test Report HTML
+          path: ${{ join('**', matrix.module, '/build/reports/tests/ios', runner.arch == 'X86' && 'X86' || runner.arch == 'X64' && 'x86_64' || runner.arch == 'ARM' && 'SimulatorArm32' || 'SimulatorArm64' ,'Test') }}