Fix track duration display #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 86.01% 86.04% +0.03%
==========================================
Files 47 47
Lines 3896 3898 +2
==========================================
+ Hits 3351 3354 +3
+ Misses 545 544 -1 ☔ View full report in Codecov by Sentry. |
pR0Ps
force-pushed
the
bugfix/duration-str
branch
from
cd73b21 to
bd53ac0
Compare
|
I wonder how this went unnoticed for so long but thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes decimal places appearing in track durations. Currently this is only shown in the playlists UI:
Also added some very basic tests to check durations around the hour boundary are properly handled.