Remove Error implementation for PkgRequest
#631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 57.61% 57.58% -0.04%
==========================================
Files 215 215
Lines 15206 15211 +5
==========================================
- Hits 8761 8759 -2
- Misses 6445 6452 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrray
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PkgRequesttype was usingthiserror::Error, which doesn't seem appropriate or necessary to me. It seems like this was added in order to get theDisplaytrait, or at least it was only being used for that, so I've added an explicit implementation and removed the derive.