Expand BuildEnv trait to include options, target and used components #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 58.00% 57.97% -0.03%
==========================================
Files 216 217 +1
Lines 15945 15996 +51
==========================================
+ Hits 9249 9274 +25
- Misses 6696 6722 +26 ☔ View full report in Codecov by Sentry. |
rydrman
force-pushed
the
296-buildenv
branch
from
f815bbf to
8d0f1b5
Compare
rydrman
changed the base branch from
254-generic-ident
to
296-solution-simplify
rydrman
changed the title
rydrman
force-pushed
the
296-solution-simplify
branch
from
01623ae to
c1a5718
Compare
jrray
reviewed
Jan 18, 2023
jrray
requested changes
Jan 31, 2023
This allows the trait to replace a number of redundant arguments where solutions were already being passed which have access to the options from the solver as desired. Signed-off-by: Ryan Bottriell <rbottriell@ilm.com>
Build environments are not just package, but must also include information about what components of each package are being used, otherwise there's not enought information to reason about the complete environment state. Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
The target identifies the package and version being built that the build environment was resolved for. This is needed for some conditionals to be able to check if the condition is for the current package or one that actually should have been resolved in the build environment itself. Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
rydrman
force-pushed
the
296-buildenv
branch
from
95a7c4f to
072505b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the trait to replace redundant arguments where solutions were already being passed which have access to the options from the solver as desired. Also adds the
BuildEnvMembertrait, expanding it to report which components were used rather than just the packages that were resolved. Finally, adds atargetto each build env that identifies the package being built.There's no practical use for these extensions in this merge, but all are required in order to manage the conditional logic that is laid out for the v1 spec format.