Formalize embedded packages as a generic type #564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 296-embedded-stub-trait #564 +/- ##
===========================================================
- Coverage 57.82% 57.70% -0.12%
===========================================================
Files 216 216
Lines 16033 16091 +58
===========================================================
+ Hits 9271 9286 +15
- Misses 6762 6805 +43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrray
requested changes
Jan 31, 2023
rydrman
force-pushed
the
296-embedded-stub-trait
branch
from
658caf7 to
e59695f
Compare
rydrman
force-pushed
the
296-embedded-stub-trait2
branch
from
c9ac9ce to
5403e14
Compare
This changes the current inheritance mechanism from being calculated based on the specific v0::Opt::inheritance field, instead expecting the package itself to identify downstream requests that need to be present. In short, this means that users need to add explicit requests to satisfy the upstream packages. As much as this is more work for users, it ensures that the final nature of each one remains up to the package definition so that they can be based on when conditions and/or attached only to specific components which is not possible now. Signed-off-by: Ryan Bottriell <rbottriell@ilm.com>
rydrman
force-pushed
the
296-embedded-stub-trait
branch
from
e59695f to
4173e28
Compare
Previously, embedded packages were assumed to be the enum spec type, which created an undesirable loop in the type hierearchy. Now, packages define their embedded stub type and it can be separate. This also extends to component specs, which also now are generic over the type of embedded package that they allow. Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
rydrman
force-pushed
the
296-embedded-stub-trait2
branch
from
5403e14 to
466625e
Compare
rydrman
force-pushed
the
296-embedded-stub-trait
branch
3 times, most recently
from
07942f4 to
541c7bd
Compare
rydrman
force-pushed
the
296-embedded-stub-trait
branch
3 times, most recently
from
7c08bd3 to
d07e319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, embedded packages were assumed to be the enum spec type, which created an undesirable loop in the type system. Now, packages declare their embedded stub type and it can be a separate one from the package itself. This also extends to component specs, which also now are generic over the type of embedded package that they allow.