Skip to content

Conversation

@rydrman
Copy link
Collaborator

@rydrman rydrman commented Nov 22, 2022

The first of a few refactorings to come. The goal here is to hide away the v0::TestSpec that was being used so that the new v1 package can use an alternate format for structuring and defining tests.

The other notable change is the logic for selecting which tests to run has become a function of the recipe itself, which will allow the v1 spec to exercise its richer when statements in this context.

Builds on #530
Part of #296

@rydrman rydrman added enhancement New feature or request Rust API Pertaining to the public rust API of the library labels Nov 22, 2022
@rydrman rydrman added this to the V1 Spec milestone Nov 22, 2022
@rydrman rydrman requested review from dcookspi and jrray November 22, 2022 05:44
@rydrman rydrman self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #560 (a260882) into main (0943b48) will decrease coverage by 0.01%.
The diff coverage is 71.62%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   53.68%   53.67%   -0.01%     
==========================================
  Files         237      238       +1     
  Lines       19101    19119      +18     
==========================================
+ Hits        10254    10263       +9     
- Misses       8847     8856       +9     
Impacted Files Coverage Δ
crates/spk/src/cli.rs 0.00% <ø> (ø)
crates/spk-schema/src/v0/spec.rs 84.41% <44.44%> (-2.58%) ⬇️
crates/spk-schema/src/recipe.rs 34.78% <66.66%> (ø)
crates/spk-schema/src/spec.rs 79.41% <70.00%> (-1.06%) ⬇️
crates/spk-schema/src/test.rs 72.00% <72.00%> (ø)
crates/spk-cli/cmd-test/src/cmd_test.rs 85.39% <100.00%> (+5.18%) ⬆️
crates/spk-cli/common/src/flags.rs 22.36% <100.00%> (-1.43%) ⬇️
crates/spk-schema/src/v0/test_spec.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rydrman rydrman mentioned this pull request Dec 23, 2022
11 tasks
@rydrman rydrman force-pushed the 256-ident-types branch 2 times, most recently from 741933c to f4ee76d Compare January 4, 2023 23:57
Base automatically changed from 256-ident-types to master January 5, 2023 23:28
Copy link
Collaborator

@jrray jrray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit!

Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
@rydrman rydrman requested review from jrray and removed request for jrray June 12, 2023 22:55
@rydrman rydrman merged commit 9f35be5 into main Jun 12, 2023
@rydrman rydrman deleted the 296-test-trait branch June 12, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Rust API Pertaining to the public rust API of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants