Adds test specs access from a build spec #1286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s test specs to be accessed from a build spec (a v0::Spec) Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jrray
approved these changes
Oct 23, 2025
| } | ||
|
|
||
| fn get_all_tests(&self) -> Vec<SpecTest> { | ||
| self.tests.clone().into_iter().map(SpecTest::V0).collect() |
jrray
reviewed
Oct 23, 2025
| Cow::Borrowed(&self.install.requirements) | ||
| } | ||
|
|
||
| fn get_all_tests(&self) -> Vec<SpecTest> { |
There was a problem hiding this comment.
I approved already, but I'm wondering if it is worth the effort to make it so this can borrow instead of clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
get_all_tests()method to the Package, Spec etc. APIs to allow a build's test specs to be accessed from a build spec (a v0::Spec). Build spec's have the data aready, but accessing it is a bit convoluted without these changes.