- 
                Notifications
    
You must be signed in to change notification settings  - Fork 9
 
Refactor FsRepository's renders #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8d8f699    to
    edf84c4      
    Compare
  
    | 
           Tests are now passing legitimately (at least locally, with an spfs installed from this code). What's left besides general cleanup is creating some new tests that specifically exercise the desired outcome: not creating the renders directory if using fuse. I'm not sure if that is true yet with these changes but the framework for making it possible should be there.  | 
    
7ec8e8b    to
    51a8e45      
    Compare
  
    631cc72    to
    a367c0f      
    Compare
  
    | 
           Making progress but the behavior of  I'm trying to get it so   | 
    
51a8e45    to
    470ac8b      
    Compare
  
    051f03e    to
    8140bae      
    Compare
  
    The goal is to make it so it is possible to open repo without creating the renders directory for the current user, in situations where that renders directory will not be used. Examples include when using fuse or when running `spfs clean`. This introduces different flavors of a "render store" besides `RenderStore` that either represent a render store that hasn't been created yet (but can be) or the lack of a render store. Operations that don't require a render store can access the local repository without the renders directory being created. Signed-off-by: J Robert Ray <jrray@jrray.org>
Test that the renders directory is not created when using fuse. Signed-off-by: J Robert Ray <jrray@jrray.org>
Expand the clean tests to test the multiple flavors of FS repo. Signed-off-by: J Robert Ray <jrray@jrray.org>
Signed-off-by: J Robert Ray <jrray@jrray.org>
8140bae    to
    e3cf272      
    Compare
  
    470ac8b    to
    60add1c      
    Compare
  
    
The goal is to make it so it is possible to open repo without creating the renders directory for the current user, in situations where that renders directory will not be used. Examples include when using fuse or when running
spfs clean.This introduces different flavors of a "render store" besides
RenderStorethat either represent a render store that hasn't been created yet (but can be) or the lack of a render store. Operations that don't require a render store can access the local repository without the renders directory being created.WIP: The test suite passes1 with this code but it is unfinished.
Footnotes
On my machine... A limitation of the test suite is that it uses the installed spfs binaries instead of the spfs code in the current branch. ↩