feat(cli): add expressive interactive renderer with animated progress#75
feat(cli): add expressive interactive renderer with animated progress#75ian-pascoe merged 2 commits intomainfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55c3392b54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if result.is_ok() { | ||
| progress.set(total_steps); | ||
| } | ||
| progress.finish(); |
There was a problem hiding this comment.
Avoid marking failed self-update progress as complete
If run_current_exe_command fails (for example, install resolution/download fails), the code still calls progress.finish(), and finish() renders a line ending in complete in ... for rich mode. That produces a contradictory success-looking completion message immediately before returning an error, which is misleading during incident/debug workflows for interactive users.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Adjusted self-update progress completion behavior: the renderer now has separate finish_success() and finish_abandon() paths. run_self_update_command only emits the completion summary on success and clears the progress UI without a success-looking line when the install step fails.
| let mut progress = renderer.start_progress("self-update", total_steps); | ||
| progress.set(0); |
There was a problem hiding this comment.
Prevent overlapping progress bars in self-update
When self-update runs without --registry-root, this function starts a self-update progress bar before it calls run_update_command, and run_update_command now starts its own progress bar too. Because both are active in the same interactive run, their animated draws can interleave and garble terminal output, making step/status messages hard to read.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Updated self-update sequencing to avoid overlapping progress bars. The self-update progress bar now starts only after the optional nested run_update_command returns, so the nested update bar finishes before self-update progress starts. This removes concurrent animated draws in the same terminal session.
Summary
Test Plan