Skip to content

fix(installer): handle flattened macOS app-bundle binary paths (SPI-35)#62

Merged
ian-pascoe merged 2 commits intomainfrom
feature/spi-35-bug-crosspack-neovide-app-bundle
Feb 26, 2026
Merged

fix(installer): handle flattened macOS app-bundle binary paths (SPI-35)#62
ian-pascoe merged 2 commits intomainfrom
feature/spi-35-bug-crosspack-neovide-app-bundle

Conversation

@ian-pascoe
Copy link
Contributor

@ian-pascoe ian-pascoe commented Feb 26, 2026

Summary

  • fix binary path validation for macOS app bundles when archive extraction is rooted at Contents/...
  • add a narrow fallback resolver for declared paths like *.app/Contents/MacOS/...
  • keep non-app-bundle behavior unchanged
  • add regression tests for both app-bundle fallback and non-app-bundle guard paths

Testing

  • rustup run stable cargo test -p crosspack-installer expose_binary_ -- --nocapture
  • rustup run stable cargo test -p crosspack-installer

Closes SPI-35

@ian-pascoe
Copy link
Contributor Author

@codex review for bugs and security issues. Particularly, make sure cross-platform functionality is still working as expected

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ian-pascoe ian-pascoe merged commit 9791946 into main Feb 26, 2026
6 checks passed
@ian-pascoe ian-pascoe deleted the feature/spi-35-bug-crosspack-neovide-app-bundle branch February 26, 2026 00:28
@crosspack-bot crosspack-bot bot mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant