Skip to content

fix(cli): initialize zsh completion system before registration#46

Merged
ian-pascoe merged 1 commit intomainfrom
fix/zsh-compinit-order
Feb 24, 2026
Merged

fix(cli): initialize zsh completion system before registration#46
ian-pascoe merged 1 commit intomainfrom
fix/zsh-compinit-order

Conversation

@ian-pascoe
Copy link
Contributor

Summary

  • fix zsh completion script ordering so compinit -i runs before compdef _crosspack crosspack
  • keep existing bash/fish/powershell completion loader behavior unchanged
  • add a regression test that fails if zsh registration happens before compinit initialization

Test Plan

  • rustup run stable cargo test -p crosspack-cli

@ian-pascoe
Copy link
Contributor Author

@codex review thoroughly for bugs and security issues

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ian-pascoe ian-pascoe merged commit ee4c226 into main Feb 24, 2026
4 checks passed
@ian-pascoe ian-pascoe deleted the fix/zsh-compinit-order branch February 24, 2026 15:54
@crosspack-bot crosspack-bot bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant