[pull] master from zimfw:master #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
and change initialization so ZIM_HOME is required before sourcing the script.
This reverts commit 9a47fde.
or if it's a symlink or not a regular file. This makes more sense now that zimfw.zsh can exist outside ZIM_HOME, that the same file can be used my multiple users in the same machine, and that it is going to be possible to install it with a package manager once it's stable to do so.
to zimfw.zsh or if it's a symlink or not a regular file. It does not make sense to show a message to user saying "Run zimfw upgrade to upgrade" if the action will then fail.
for write permission. Also, if ZIM_HOME is not defined, don't "autoload" the zimfw function, since this is going to be a scenario where the user only has something like `source /path/to/zim/init.zsh` in their .zshrc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )