-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of things to try and get publishing working #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e30c11.
a10y
commented
Aug 8, 2024
Comment on lines
+14
to
+15
xtask = "run -p xtask --" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/matklad/cargo-xtask
this seems like it's on defacto standard in the rust ecosystem for repo automation stuff
robert3005
approved these changes
Aug 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to change the way we do a few things to get crates.io publishing working for our workspace:
vortex-build
and its use ofcargo metadata
at compile time was causing lock files to get regenerated, which causedcargo publish
to fail. In general, the way pretty much all major projects seem to handle codegen is to do it ahead of time. To that end,vortex-build
has been removed completely, supplanted with thextask
setup described belowMoved all flatbuffer definitions into
vortex-flatbuffers
. Clients of that crate can select which subset of the definitions they want to compile with using features, current features are:vortex-proto
to mirrorvortex-flatbuffers
but for protobuf definitions. Features on that crate:xtask
binary crate, runnable viacargo xtask -h
with commands to execute codegen for both flatbuffers and protobufs. Currently has two subcommands available: