Dict null code can be any index instead of just 0 #2208
+151
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
changed the title
robert3005
changed the title
robert3005
force-pushed
the
rk/dictnullcode
branch
from
e1c4df3 to
d6fb340
Compare
robert3005
force-pushed
the
rk/dictnullcode
branch
from
67e902e to
fedba15
Compare
|
Do we only allow a single null value in each dict? |
|
For now yes, I guess that's what your pr will change? |
|
|
||
| Ok(true) | ||
| } | ||
|
|
||
| fn validity_mask(&self, array: &DictArray) -> VortexResult<Mask> { | ||
| if array.dtype().is_nullable() { | ||
| if let Some(null_code) = array.null_code() { |
There was a problem hiding this comment.
I think that values can have more than one null value in the values?
|
Do we either note that in docs or check it? |
|
Just so we know, this isn't zero-copy from arrow. there's no reason dictionary values need to be unique.... |
|
Correct, the existing one isn’t either. I was assuming that comes in a future pr |
|
Well the existing and this thing assume there's only one null code |
|
indeed, this was meant to unwind #2206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.