fix: compress_noci benchmark broken on develop #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
approved these changes
Nov 22, 2024
robert3005
reviewed
Nov 22, 2024
| if let Some(cc) = ConstantCompressor.can_compress(array) { | ||
| return cc.compress(array, None, self.clone()); | ||
| // short-circuit because seriously nothing beats constant | ||
| if self.is_enabled(&ConstantCompressor) && ConstantCompressor.can_compress(array).is_some() { |
There was a problem hiding this comment.
Was the brokeness here that we disabled the compressor and looped forever?
There was a problem hiding this comment.
no, it was that we disabled ConstantCompressor when compressing FSST codes (since we only want to compress the offsets inside the codes VarBin), but this ignored that. FSST::try_new requires codes to have VarBin encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was accidentally broken in #1430