Vortex Error #133
Merged
Vortex Error #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
approved these changes
Mar 25, 2024
|
Let's say this fixes #125 |
lwwmanning
reviewed
Mar 25, 2024
| use crate::scalar::Scalar; | ||
|
|
||
| // TODO(ngates): convert this to arithmetic operations with macro over the kernel. | ||
| pub fn add(lhs: &dyn Array, rhs: &dyn Array) -> VortexResult<ArrayRef> { | ||
| // Check that the arrays are the same length. | ||
| let length = lhs.len(); | ||
| if rhs.len() != length { | ||
| return Err(VortexError::LengthMismatch); | ||
| return Err("Arrays have different lengths".into()); |
| @@ -51,7 +51,7 @@ impl ALPArray { | |||
| pub fn encode(array: &dyn Array) -> VortexResult<ArrayRef> { | |||
| match ArrayKind::from(array) { | |||
| ArrayKind::Primitive(p) => Ok(alp_encode(p)?.into_array()), | |||
| _ => Err(VortexError::InvalidEncoding(array.encoding().id())), | |||
| _ => Err("ALP can only encoding primitive arrays".into()), | |||
There was a problem hiding this comment.
s/encode/encoding/
also might be nice to propagate information about what encoding was passed in?
| @@ -15,8 +16,8 @@ impl PatchFn for PrimitiveArray { | |||
| // TODO(ngates): support a default implementation based on iter_arrow? | |||
| _ => Err(VortexError::MissingKernel( | |||
| "patch", | |||
| self.encoding().id(), | |||
| vec![patch.encoding().id()], | |||
| self.encoding().id().0, | |||
| @@ -34,7 +34,7 @@ impl RoaringIntArray { | |||
|
|
|||
| pub fn try_new(bitmap: Bitmap, ptype: PType) -> VortexResult<Self> { | |||
| if !ptype.is_unsigned_int() { | |||
| return Err(VortexError::InvalidPType(ptype)); | |||
| return Err("RoaringInt expected unsigned int".into()); | |||
There was a problem hiding this comment.
... "expected unsigned int ptype" and then inline what was received
| @@ -55,7 +55,7 @@ impl RoaringIntArray { | |||
| pub fn encode(array: &dyn Array) -> VortexResult<Self> { | |||
| match ArrayKind::from(array) { | |||
| ArrayKind::Primitive(p) => Ok(roaring_encode(p)), | |||
| _ => Err(VortexError::InvalidEncoding(array.encoding().id())), | |||
| _ => Err("RoaringInt can only encode primitive arrays".into()), | |||
| @@ -40,7 +40,7 @@ impl ZigZagArray { | |||
| pub fn encode(array: &dyn Array) -> VortexResult<ArrayRef> { | |||
| match ArrayKind::from(array) { | |||
| ArrayKind::Primitive(p) => Ok(zigzag_encode(p)?.into_array()), | |||
| _ => Err(VortexError::InvalidEncoding(array.encoding().id())), | |||
| _ => Err("ZigZag can only encoding primitive arrays".into()), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should do more work on our error crate, taking some inspiration from Polars.