Skip to content

Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests#1294

Open
samsonasik wants to merge 9 commits into
spiral:masterfrom
samsonasik:bump-structarmed-finalize-tests
Open

Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests#1294
samsonasik wants to merge 9 commits into
spiral:masterfrom
samsonasik:bump-structarmed-finalize-tests

Conversation

@samsonasik

Copy link
Copy Markdown
Contributor

What was changed

StructArmed 0.15.0 introduce ExtendedClassAwareRuleInterface that makes MustBeFinalRule safely be used to skip if there is class that extend target class.

This PR bump StructArmed to ^0.15 and apply the MustBeFinalRule with single command to fix.

vendor/bin/structarmed analyze --fix

Why?

Make use of final class when possible.

Checklist

  • Tested
    • Tested manually

Documentation

@samsonasik samsonasik changed the title Bump to StructArmed 0.15 and enable MustBeFinalRule on tests Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests Jul 20, 2026
@samsonasik

Copy link
Copy Markdown
Contributor Author

@roxblnfk ready to review/merge 👍

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.64%. Comparing base (e291586) to head (7f8fe8e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1294      +/-   ##
============================================
- Coverage     90.65%   90.64%   -0.02%     
  Complexity     6703     6703              
============================================
  Files           876      876              
  Lines         18978    18978              
============================================
- Hits          17204    17202       -2     
- Misses         1774     1776       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant