Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests#1294
Open
samsonasik wants to merge 9 commits into
Open
Bump to StructArmed ^0.15 and enable MustBeFinalRule on tests#1294samsonasik wants to merge 9 commits into
samsonasik wants to merge 9 commits into
Conversation
Contributor
Author
|
@roxblnfk ready to review/merge 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
============================================
- Coverage 90.65% 90.64% -0.02%
Complexity 6703 6703
============================================
Files 876 876
Lines 18978 18978
============================================
- Hits 17204 17202 -2
- Misses 1774 1776 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
StructArmed 0.15.0 introduce
ExtendedClassAwareRuleInterfacethat makesMustBeFinalRulesafely be used to skip if there is class that extend target class.This PR bump StructArmed to
^0.15and apply theMustBeFinalRulewith single command to fix.Why?
Make use of
finalclass when possible.Checklist
Documentation