List supported currencies in API under api/currencies #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for opening a pull request here. It's appreciated :-) I think adding a test for this would be helpful in order to test that it's behaving the way we think it is. Let me know if you need help on how to do this properly. |
|
Thanks for the feedback, I'm happy to add some tests. Just to confirm before I do it, I'm thinking of putting them at the start of this test_currencies and add asserts for a good status and check that |
|
Please, add them in the api tests instead, it's better to keep all the API-related tests together. |
Closed
|
Works for me, thanks! We can merge as soon as the build is green :-) |
|
Thanks :-) |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
…#961) * List supported currencies in API under api/currencies * Added test for /currencies route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #847
Returns a list of supported currencies under
/api/currencies.This is my first PR for this project, any feedback is greatly appreciated :)