Fix meter registry processor causing incompatibility with Armory's Observability plugin

[massimo-pacher-tw]

This PR fixes armory-plugins/armory-observability-plugin#32 (comment).

It allows other BeanPostProcessor (e.g. Spring MeterRegistryBeanPostProcessor) to process registry implementations, restoring the exported metrics and aligning the behavior to the other spinnaker services.

I've retrofitted a test showing the missed processing of a dummy BeanPostProcessor, but more details are available on the issue.

We noticed this issue extends to Kayenta too, given it pulls in orca-core modules and the affected classes, preventing the Observability plugin to export standard metrics (due to the binders - e.g. JvmMetrics - not being bound ).

[spinnakerbot]

The following commits need their title changed:

• ea5f84d: retrofit integration test

• 4717b56: allow registry implementations to be processed by other BeanPostProcessors

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

[mattgogerly]

Thank you for fixing this!

[dbyron-sf]

Yes, thanks much @massimo-pacher-tw! If kayenta picks up the fix by releasing a new version of orca, and doesn't have any place to fix directly within kayenta, then I think we're set. We'll figure out a good time to tag orca and bump the version in kayenta.

[massimo-pacher-tw]

Yes, thanks much @massimo-pacher-tw! If kayenta picks up the fix by releasing a new version of orca, and doesn't have any place to fix directly within kayenta, then I think we're set. We'll figure out a good time to tag orca and bump the version in kayenta.

It seems that's enough yes, I've just deployed our fork using the new, fixed, orca version and metrics appear correctly.

[dbyron-sf]

I tagged v8.21.0 of orca with this fix. Here's the kayenta PR to pick up the change.

[massimo-pacher-tw]

I did the exact same fix in our fork, thanks for the bump 🙇‍♂️