-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meter registry processor causing incompatibility with Armory's Observability plugin #4224
Fix meter registry processor causing incompatibility with Armory's Observability plugin #4224
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
Allow registry implementations to be processed by other BeanPostProcessors Fix armory-plugins/armory-observability-plugin#32
4717b56
to
98251a9
Compare
Thank you for fixing this! |
Yes, thanks much @massimo-pacher-tw! If kayenta picks up the fix by releasing a new version of orca, and doesn't have any place to fix directly within kayenta, then I think we're set. We'll figure out a good time to tag orca and bump the version in kayenta. |
It seems that's enough yes, I've just deployed our fork using the new, fixed, orca version and metrics appear correctly. |
I tagged v8.21.0 of orca with this fix. Here's the kayenta PR to pick up the change. |
I did the exact same fix in our fork, thanks for the bump 🙇♂️ |
This PR fixes armory-plugins/armory-observability-plugin#32 (comment).
It allows other
BeanPostProcessor
(e.g. SpringMeterRegistryBeanPostProcessor
) to process registry implementations, restoring the exported metrics and aligning the behavior to the other spinnaker services.I've retrofitted a test showing the missed processing of a dummy BeanPostProcessor, but more details are available on the issue.
We noticed this issue extends to Kayenta too, given it pulls in
orca-core
modules and the affected classes, preventing the Observability plugin to export standard metrics (due to the binders - e.g. JvmMetrics - not being bound ).