Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent store #1493

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent store #1493

merged 1 commit into from
Aug 23, 2024

Conversation

christosarvanitis
Copy link
Member

@christosarvanitis christosarvanitis commented Aug 22, 2024 •
edited
Loading

By fixing the GCS to SQL migration in this PR and removing the hardcoded "specification.json" from the GCSStorageService i cause an issue with all ObjectTypes except the Application and ApplicationPermission.

More specifically the offending change is this one which had an effect in all the other ObjectTypes in GCS to get/store the filenames defined in the ObjectType and not the previously used specification.json for GCS.

Fixes issue spinnaker/spinnaker#6970

This was referenced Aug 22, 2024
Merged
Closed
@dbyron-sf
Copy link
Contributor

What's involved in adding a test to prevent this bug in the future?

@christosarvanitis
Copy link
Member Author

What's involved in adding a test to prevent this bug in the future?

Let me see what we have here. Probably simulate a GCS bucket with existing objects (application, serviceaccounts, projects etc) and filenames specification.json. And retrieving them in a test.

@dbyron-sf automatically closed by the merge?

@dbyron-sf dbyron-sf reopened this Aug 22, 2024
@dbyron-sf
Copy link
Contributor

@dbyron-sf automatically closed by the merge?

Yeah, github is too smart...I re-opened.

@christosarvanitis
Copy link
Member Author

@dbyron-sf Added some tests to cover all types loading

@dbyron-sf
Copy link
Contributor

Thank you!

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Aug 23, 2024
@mergify mergify bot added the auto merged label Aug 23, 2024
@mergify mergify bot merged commit 2f828b7 into spinnaker:master Aug 23, 2024
4 checks passed
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.34.x release-1.35.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 23, 2024 •
edited
Loading

backport release-1.34.x release-1.35.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
@christosarvanitis @mergify
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
8137148 
… store (#1493)

(cherry picked from commit 2f828b7)
@mergify mergify bot mentioned this pull request Aug 23, 2024
Merged
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
@christosarvanitis @mergify
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
07fe2f7 
… store (#1493)

(cherry picked from commit 2f828b7)
@mergify mergify bot mentioned this pull request Aug 23, 2024
Merged
mergify bot added a commit that referenced this pull request Aug 23, 2024
@mergify @christosarvanitis
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
25bda17 
… store (#1493) (#1494)

(cherry picked from commit 2f828b7)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Aug 23, 2024
@mergify @christosarvanitis
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
210501b 
… store (#1493) (#1495)

(cherry picked from commit 2f828b7)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
@jasonmcintosh
Copy link
Member

https://github.com/Mergifyio backport release-1.32.x release-1.33.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 26, 2024 •
edited
Loading

backport release-1.32.x release-1.33.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@christosarvanitis @mergify
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
15b7d0e 
… store (#1493)

(cherry picked from commit 2f828b7)
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@christosarvanitis @mergify
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
ba531b4 
… store (#1493)

(cherry picked from commit 2f828b7)
This was referenced Aug 26, 2024
Merged
Merged
mergify bot added a commit that referenced this pull request Aug 27, 2024
@mergify @christosarvanitis
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
78a33c3 
… store (#1493) (#1497)

(cherry picked from commit 2f828b7)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Aug 27, 2024
@mergify @christosarvanitis
fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent…
de49a6d 
… store (#1493) (#1496)

(cherry picked from commit 2f828b7)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.36
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christosarvanitis @dbyron-sf @jasonmcintosh @spinnakerbot