feat(plugins): Add echo-plugins-test module #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
force-pushed
the
echo-plugins-test
branch
from
52a22cf to
6855a34
Compare
robzienert
reviewed
Apr 14, 2020
| @@ -0,0 +1,29 @@ | |||
| apply from: "${project.rootDir}/gradle/kotlin.gradle" | |||
There was a problem hiding this comment.
I thought we were going to move these to {app}-api-test?
There was a problem hiding this comment.
I was thinking we'd have {app}-api, {app}-api-tck, and {app}-plugins-test. I guess the last one could be called {app}-api-test. This module is really about loading actual plugins into the app, which is why I think it makes sense to have plugins in the name. 🤔
There was a problem hiding this comment.
Also, this is following the same pattern I have put in place in Orca and Gate.
robzienert
reviewed
Apr 14, 2020
jonsie
force-pushed
the
echo-plugins-test
branch
from
6855a34 to
c381794
Compare
jonsie
added
WIP
|
Setting this to "do not merge" until we have pulled in these Gradle changes -- spinnaker/spinnaker-gradle-project#121 Without that, these tests fail when pulling in the existing dependencies in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.