(kubernetes) Only strip underscores from names #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielpeach @leelasharma Turns out the only invalid character in a docker repo name is the underscore: https://github.com/docker/docker/blob/f63cdf0260cf6287d28a589a79d3f947def6a569/runtime.go#L33 - so we can keep the dash.
|
LGTM |
kmarquardsen
pushed a commit
to target/deck
that referenced
this pull request
Aug 19, 2016
* 'master' of github.com:spinnaker/deck: Address the spacing-related linter warnings. (spinnaker#2596) core/bake: Add support for 'varFileName' attribute to bake stages. (spinnaker#2594) (kubernetes) Only strip underscores from names (spinnaker#2593) SpEL autocomplete (spinnaker#2588) (titus) replace titus tiny icon (spinnaker#2587) (core) add quip stage description link (spinnaker#2586) provider/cf: Allow resizing to include memory and disk (spinnaker#2585) guard against undefined while loading docker image (spinnaker#2584) (core) added retry service, updated docker image reader with retries (spinnaker#2582) (netflix) include link to documentation (spinnaker#2583) Openstack Security group support for UDP and ICMP (spinnaker#2580) Add image list to clusters and project (spinnaker#2530) * (gce) load balancer detail panel includes health check for each backend (spinnaker#2581) (cf) Add 'disk limit' as an advanced setting to server group settings (spinnaker#2579) (gce) updated max vcpu list (spinnaker#2569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielpeach @leelasharma
Turns out the only invalid character in a docker repo name is the underscore: https://github.com/docker/docker/blob/f63cdf0260cf6287d28a589a79d3f947def6a569/runtime.go#L33 - so we can keep the dash.