(aws) Allow selection of VPC load balancers on Classic ASGs #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var testVpc = test.vpcId || null; | ||
| return test.name === loadBalancer.name && test.region === loadBalancer.region && test.account === loadBalancer.accountId && testVpc === loadBalancer.vpcId; | ||
| })[0]; | ||
| let [appLoadBalancer] = app.loadBalancers.data.filter(function (test) { |
There was a problem hiding this comment.
What does wrapping a variable name in square brackets do? Is it to coerce the outputs of the filter into an array?
There was a problem hiding this comment.
Yeah, exactly - it's using ES6 array destructuring. Since filter returns an array, this sets appLoadBalancer to the first item in the array (or undefined if the filter returns an empty collection).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS allows users to attach any load balancer to any ASG, regardless of its VPC association.
We're taking a more opinionated approach here, only allowing Classic ASGs to attach to VPC load balancers (not letting VPC ASGs attach to Classic ELBs). This is to help folks migrate away from Classic by slowly shifting traffic over to VPC instances.
We don't expect this to be heavily utilized, but it's important for teams that need to migrate over incrementally.
@zanthrash PTAL
(If the link is clicked, or VPC load balancers have been selected)
